-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-118689: fix ePub build #118690
gh-118689: fix ePub build #118690
Conversation
With this fix, I can open the epub file with Books.app in macOS. There are many other errors reported by epubcheck. |
Another issue: |
Remaining errors: $ epubcheck --locale en-US build/epub/Python.epub 2>python-epub-errors.txt https://gist.github.com/methane/03a569934bec14a2b4b2a783f96d01b3 |
I found epub_use_index option so I use it to disable index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes.
With this fix, I can open the epub file with Books.app in macOS.
Same here 👍
There are many other errors reported by epubcheck.
This sounds like something we should aim to add to the CI, even if we start with a subset of passing checks.
Thanks also for opening issues in the extensions.
Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
(cherry picked from commit 7ac933e) Co-authored-by: Inada Naoki <[email protected]>
(cherry picked from commit 7ac933e) Co-authored-by: Inada Naoki <[email protected]>
GH-118889 is a backport of this pull request to the 3.13 branch. |
GH-118890 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit 7ac933e) Co-authored-by: Inada Naoki <[email protected]>
(cherry picked from commit 7ac933e) Co-authored-by: Inada Naoki <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--118690.org.readthedocs.build/