Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix which port the ADIS16470 is plugged into by default #2421

Closed
wants to merge 4 commits into from
Closed

Fix which port the ADIS16470 is plugged into by default #2421

wants to merge 4 commits into from

Conversation

Technologyman00
Copy link

The documentation says that the ADIS16470 is plugged into the MXP by default which is not true. It should say SPI Port

Reference: https://first.wpi.edu/wpilib/allwpilib/docs/release/java/src-html/edu/wpi/first/wpilibj/ADIS16470_IMU.html#line.281

image

@sciencewhiz sciencewhiz changed the base branch from stable to main December 8, 2023 02:31
@sciencewhiz sciencewhiz changed the base branch from main to stable December 8, 2023 02:33
@sciencewhiz
Copy link
Collaborator

Per https://docs.wpilib.org/en/stable/docs/contributing/frc-docs/contribution-guidelines.html#creating-a-pr PRs should be targeted to main. Please rebase on main.

@Technologyman00 Technologyman00 changed the base branch from stable to main December 8, 2023 03:25
@Technologyman00
Copy link
Author

Ok I made the change. Apologies

@sciencewhiz
Copy link
Collaborator

the commit needs to be rebased on main, not just the base branch changed, since it now picks up unrelated changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants