[cmd] Allow specifying initial condition of Trigger bindings #7425
+500
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
|
Mac failures seem unrelated. (One is Mac CMake having trouble with dependencies, the other is a flaky ntcore test) |
wpilibNewCommands/src/main/native/include/frc2/command/button/Trigger.h
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Trigger.java
Outdated
Show resolved
Hide resolved
Running into issues making the PR (See robotpy/robotpy-commands-v2#77), if anyone wants to do it for me that'd be greatly appreciated. (If not, I'll write the PR eventually and rely on CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone has a better name for
NEG_CONDITION, please let me know!Fixes #7413 and fixes #5608 by letting users specify
NEG_CONDITIONto force an initial edge orFALSEto force an initial edge if the condition is true.