Use div instead of divide for kotlin compatibility #7387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The geometry classes did in fact use that naming for compatibility with Kotlin operator overloading. |
|
@SamCarlberg for your consideration |
sciencewhiz
added a commit
to Beachbot330/allwpilib
that referenced
this pull request
Nov 27, 2024
It was changed to div in wpilibsuite#7387, but 2024 used divide.
sciencewhiz
added a commit
to Beachbot330/allwpilib
that referenced
this pull request
Nov 27, 2024
It was changed to div in wpilibsuite#7387, but 2024 used divide.
sciencewhiz
added a commit
to Beachbot330/allwpilib
that referenced
this pull request
Nov 27, 2024
It was changed to div in wpilibsuite#7387, but 2024 used divide.
sciencewhiz
added a commit
to Beachbot330/allwpilib
that referenced
this pull request
Nov 28, 2024
It was changed to div in wpilibsuite#7387, but 2024 used divide.
sciencewhiz
added a commit
to Beachbot330/allwpilib
that referenced
this pull request
Nov 28, 2024
It was changed to div in wpilibsuite#7387, but 2024 used divide.
PeterJohnson
pushed a commit
that referenced
this pull request
Nov 28, 2024
It was changed to div in #7387, but 2024 used divide.
katzuv
pushed a commit
to katzuv/allwpilib
that referenced
this pull request
Feb 16, 2025
katzuv
pushed a commit
to katzuv/allwpilib
that referenced
this pull request
Feb 16, 2025
It was changed to div in wpilibsuite#7387, but 2024 used divide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other operators follow the kotlin operator names (whether on purpose of not), and it would be nice if division followed suite