-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage reporting for dashboards as instances #7294
Conversation
Detects dashboards based on network tables client identity Depends on wpilibsuite#7293 to detect SmartDashboard
} else { | ||
// Only report unknown if there wasn't another dashboard already reported | ||
// (unknown could also be another device) | ||
if (!m_detected) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would likely report a coprocessor as an unknown dashboard before a DS laptop connects, right? I presume we're okay with that, just calling it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but if a dashboard connected later, it would override the unknown. I just didn't want the unknown to override something known.
I'm a big fan of this PR, there's one concerning change that I want to let you know about. Within the next update for Elastic I'm going to change the client identity from "elastic" to "Elastic". To prevent this from causing it to be reported as unknown there should be some sort of case-insensitive check or add |
294ae10
to
690234e
Compare
254530b
to
de55257
Compare
Detects dashboards based on network tables client identity
Depends on #7293 to detect SmartDashboard