Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd] Deprecate control commands and subsystems #7143

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Oct 1, 2024

Resolves #5352, closes #5067, depends on #7054.

@Gold856 Gold856 requested a review from a team as a code owner October 1, 2024 20:01
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@rzblue
Copy link
Member

rzblue commented Oct 1, 2024

Just like the previous PRs, there needs to be changes to examples and documentation to demonstrate the preferred approach.

@Gold856
Copy link
Contributor Author

Gold856 commented Oct 1, 2024

Progress on that is essentially done and is just waiting for review/merge. wpilibsuite/frc-docs#2684 covers the frc-docs portion, #7030 covers the last example that needs modernization and #7054 removes everything else. After everything is merged, RapidReactCommandBot will hold the new (inlined) examples and there will be no more instances of the old control commands/subsystems.

@rzblue
Copy link
Member

rzblue commented Oct 2, 2024

Is wpilibsuite/frc-docs#2684 waiting on #7030? There's still a number of references to control commands.

@Gold856
Copy link
Contributor Author

Gold856 commented Oct 2, 2024

Yes, I need #7030 merged before I can fully remove the remaining references to control commands.

@Gold856 Gold856 force-pushed the deprecate-control-commands-and-subsystems branch 5 times, most recently from 221cf1b to 84d0d5e Compare October 11, 2024 06:47
@Gold856 Gold856 force-pushed the deprecate-control-commands-and-subsystems branch from 84d0d5e to 95cc2fc Compare October 11, 2024 07:00
@PeterJohnson PeterJohnson merged commit 22a04bf into wpilibsuite:main Oct 12, 2024
33 checks passed
@Gold856 Gold856 deleted the deprecate-control-commands-and-subsystems branch October 12, 2024 03:29
katzuv pushed a commit to katzuv/allwpilib that referenced this pull request Oct 14, 2024
spacey-sooty pushed a commit to spacey-sooty/allwpilib that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate PIDCommand and PIDSubsystem
4 participants