Make Command tests use command factories and decorators. #7006
Conversation
command1 and command2 are mock Commands that don't actually implement Command decorators
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
|
/format |
|
/format |
|
I think I got everything? I'm not familiar with C++ so might have missed some/done things poorly. |
There was a problem hiding this comment.
Sorry for the delay, but overall, great work! Unfortunately, some usages of new RunCommand() were added to CommandDecoratorTest since the issue was opened, so those will also need to be converted. There's some spots in C++ that should be adjusted, but they involve replacing command types with CommandPtr, which is a little more complicated. If you want to learn a little bit of C++ and work on doing it, go ahead! If you want help, just let us know (in this issue or on Discord) and we'll be happy to help too.
Here's the missing spots in C++ (that I've noticed, I might've missed some):
AddRequirementsTestCommandDecoratorTest.WithNameParallelCommandGroupTest.ParallelGroupCopyParallelCommandGroupTest.ParallelGroupRequirementParallelDeadlineGroupTest.ParallelDeadlineCopyParallelDeadlineGroupTest.ParallelDeadlineRequirementParallelRaceGroupTest.ParallelRaceCopyParallelRaceGroupTest.RaceGroupRequirementParallelRaceGroupTest.ParallelRaceOnlyCallsEndOncePOVButtonTest.SetPOVScheduleCommandTest.ScheduleCommandScheduleSchedulerTestSchedulingRecursionTestSelectCommandTest.SelectCommandRequirementSequentialCommandGroupTest.SequentialGroupCopySequentialCommandGroupTest.SequentialGroupRequirement
TheComputer314
changed the title
Some of the tests are going to be better kept as-is, don't try to force them to work with decorators. |
Does the Java portion of #6652.
May have missed some command declarations that should be changed, as I went off of the list compiled in the issue.
Tests all pass on my end.