Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trigger.onChange() test #6849

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Add Trigger.onChange() test #6849

merged 2 commits into from
Jul 27, 2024

Conversation

WispySparks
Copy link
Contributor

Resolves #6777

@WispySparks WispySparks requested a review from a team as a code owner July 18, 2024 01:42
@github-actions GitHub Actions
Copy link
Contributor

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@WispySparks
Copy link
Contributor Author

Test already exists in python - https://github.com/robotpy/robotpy-commands-v2/blob/125788eac2998a8fb89ac9533b8ee5b7ac2516f9/tests/test_trigger.py#L45

@spacey-sooty
Copy link
Contributor

Contributor

FYI the fact this didn't have a test was actually picked up by the Python team

@PeterJohnson PeterJohnson merged commit 5a1417a into wpilibsuite:main Jul 27, 2024
34 checks passed
@WispySparks WispySparks deleted the trigger-onchange-test branch July 28, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty approved these changes

@rzblue rzblue rzblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger.onChange has no test
4 participants
@WispySparks @spacey-sooty @rzblue @PeterJohnson