Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usage reporting for loggers #7450

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Add usage reporting for loggers #7450

merged 1 commit into from
Nov 30, 2024

Conversation

sciencewhiz
Copy link
Contributor

Fixes #6606
Fixes #6918

@sciencewhiz sciencewhiz requested review from a team as code owners November 29, 2024 22:31
spacey-sooty
spacey-sooty reviewed Nov 30, 2024
View reviewed changes
Copy link
Contributor

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this report Epilogue usage as well?

@sciencewhiz
Copy link
Contributor Author

It takes a lot more to report epilogue since it's a different subproject so it needs something like is done in wpimath. So I think that's better done I a separate PR.

@PeterJohnson PeterJohnson merged commit 0941251 into wpilibsuite:main Nov 30, 2024
44 checks passed
@sciencewhiz sciencewhiz deleted the LoggingUsageReport branch November 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty left review comments

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add usage reporting for epilogue Add usage reporting ID for DataLogManager (and/or DataLog)
3 participants
@sciencewhiz @PeterJohnson @spacey-sooty