Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE-INFRA] 기존 디비 ec2에 있는 도커를 dev ec2안으로 옮긴다 #351

Merged
merged 9 commits into from
Oct 11, 2024
Merged

[BE-INFRA] 기존 디비 ec2에 있는 도커를 dev ec2안으로 옮긴다 #351

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4047264
refactor: 커밋 시점 수정
unifolio0 Oct 4, 2024
1a59ebc
refactor: 커밋 시점 수정
unifolio0 Oct 4, 2024
cf00222
refactor: 커밋 시점 수정
unifolio0 Oct 4, 2024
eab658e
refactor: 커밋 시점 변경
unifolio0 Oct 4, 2024
7d681a8
refactor: 수정
unifolio0 Oct 4, 2024
3b29ac7
refactor: 스크립트 수정
unifolio0 Oct 4, 2024
28ff09b
refactor: secret으로 변경 및 캐시 삭제
unifolio0 Oct 7, 2024
1cd343f
refactor: 인덴트 제거
unifolio0 Oct 11, 2024
3b4611f
chore: 서브 모듈 커밋 시점 변경
unifolio0 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/Backend-CD-Dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ jobs:
uses: ./.github/workflows/Backend-CI.yml
secrets: inherit


build:
needs: test
runs-on: dev
dwax1324 marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -56,14 +55,18 @@ jobs:
sudo chmod 666 /var/run/docker.sock

if [ "$(docker ps -qa)" ]; then
docker rm -f $(docker ps -qa)
docker rm -f $(docker ps -qa)
docker builder prune
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인 질문인데, docker 이미지를 지우고 다시 이미지를 빌드하는 과정을 CD에 넣으신 이유가 궁금했어요!

왜냐면 CI가 먼저 선행되고 , 거기서 체크 표시가 안떠서 문제가 되는 경우가 많았거든요 🥹
비토의 상황도 비슷했던 것으로 기억합니다!

CI 의 빌드속도가 느려지긴 하겠지만 개인적으로 CD가 느려지기 보다는 CI가 느린게 낫다는 생각이긴 합니다 🤔

근데 개인적인 의견이라서 지금 캠퍼스에 계신 분들끼리 판단해서 정해주셔도 될 것 같아요! 😋

Copy link
Author

@unifolio0 unifolio0 Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희 CI 돌아가는 ec2랑 CD 돌아가는 ec2가 달라서 해당 로직이 필요할 것 같아요!☺️☺️

else
echo "No containers to remove."
echo "No containers to remove."
dwax1324 marked this conversation as resolved.
Show resolved Hide resolved
fi


docker pull ${{ secrets.DOCKER_DEV_MONGO_IMAGE }}
docker run -d --name pokerogue-mongo-db ${{ secrets.DOCKER_DEV_MONGO_IMAGE }}

docker pull ${{ secrets.DOCKER_DEV_SERVER_IMAGE }}

docker run -d -p 8080:8080 --name server \
--link pokerogue-mongo-db \
-e JAVA_OPTS="-XX:InitialRAMPercentage=70.0 -XX:MaxRAMPercentage=70.0" \
-e TZ=Asia/Seoul \
-e SPRING_PROFILES_ACTIVE=dev \
Expand Down
2 changes: 1 addition & 1 deletion backend/pokerogue/src/main/resources
Open in desktop
Submodule resources updated from 93fd3d to 7e521e
Loading