-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE-INFRA] 기존 디비 ec2에 있는 도커를 dev ec2안으로 옮긴다 #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비토 고생하셨습니다 👍
dev yml 파일을 보니 제가 예전에 달았던 주석도 있는데 제거하면 더 좋을 것 같아요 👍 (이제 db가 로컬호스트로 바뀌었는데 헷갈릴 거 같아서 ㅎㅎ)
.github/workflows/Backend-CD-Dev.yml
Outdated
docker run -d -p 8080:8080 --name server \ | ||
--link pokerogue-mongo-db:mongo \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네트워크 연결을 해줬군요 👍 그런데 mongo 라는 별칭을 지정해줘도 잘 돌아가나요? yml 파일을 보니 db url이 pokerogue-mongo-db:27017
으로 되어 있어서요!
(잘 돌아가더라도 별칭을 사용하지 않는다면 붙여주지 않아도 되지 않을까요?!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!
.github/workflows/Backend-CD-Dev.yml
Outdated
|
||
|
||
# Pull and run the MongoDB container | ||
docker pull pokeroguehelper/pokerogue-helper-test-mongodb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI 워크플로우에서 docker image caching으로 문제가 있던 걸로 기억하는데 pull 받기 전에 docker image를 지우는 과정은 필요 없을까요 ?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!
.github/workflows/Backend-CD-Dev.yml
Outdated
|
||
# Pull and run the MongoDB container | ||
docker pull pokeroguehelper/pokerogue-helper-test-mongodb | ||
docker run -d --name pokerogue-mongo-db pokeroguehelper/pokerogue-helper-test-mongodb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!
/noti 비토 리뷰 완! |
/noti 미아 리뷰 반영 완! |
.github/workflows/Backend-CD-Dev.yml
Outdated
@@ -56,14 +55,18 @@ jobs: | |||
sudo chmod 666 /var/run/docker.sock | |||
|
|||
if [ "$(docker ps -qa)" ]; then | |||
docker rm -f $(docker ps -qa) | |||
docker rm -f $(docker ps -qa) | |||
docker builder prune |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인 질문인데, docker 이미지를 지우고 다시 이미지를 빌드하는 과정을 CD에 넣으신 이유가 궁금했어요!
왜냐면 CI
가 먼저 선행되고 , 거기서 체크 표시가 안떠서 문제가 되는 경우가 많았거든요 🥹
비토의 상황도 비슷했던 것으로 기억합니다!
CI 의 빌드속도가 느려지긴 하겠지만 개인적으로 CD가 느려지기 보다는 CI가 느린게 낫다는 생각이긴 합니다 🤔
근데 개인적인 의견이라서 지금 캠퍼스에 계신 분들끼리 판단해서 정해주셔도 될 것 같아요! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희 CI
돌아가는 ec2랑 CD
돌아가는 ec2가 달라서 해당 로직이 필요할 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미 미아가 많은 리뷰를 해줬네요! 👍🏻
LGTM 입니다! 비토한테도 도커 배워야겠네요 😄
궁금한거 하나 달았습니다! 확인해주세요!
/noti 비토 리뷰 한번 확인 부탁! |
/noti 폴라 리뷰 답변 완! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비토! 미아 pr보고 궁금한점 코멘트 남겼습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
슛~
🍄 PR 확인 사항
PR이 다음 요구 사항을 충족하는지 확인하세요. :
API 명세서가 업데이트 혹은 작성이 되어 있나요?
기존 디비 ec2에 있는 도커를 dev ec2안으로 옮긴다.
기존 코드에서 변경된 점이 있다면 설명해주세요. (추가 X)