Add support for PowerPC 32-bit SHA256 assembly speedups#576
Merged
danielinux merged 5 commits intowolfSSL:masterfrom Jun 24, 2025
Merged
Add support for PowerPC 32-bit SHA256 assembly speedups#576danielinux merged 5 commits intowolfSSL:masterfrom
danielinux merged 5 commits intowolfSSL:masterfrom
Conversation
…r ELF loading to set entry point before copying sections (resolves issue with loading on top of current location). Rename elf_load_image_mmu argument `entry` to `pentry` to avoid confusion with GET_H64 macro's use of header member "entry".
…ailure because of NO_FILESYTEM.
4 tasks
… cert gen, crypto callback missing max digest size).
4 tasks
rizlik
previously approved these changes
Jun 24, 2025
Contributor
rizlik
left a comment
rizlik
left a comment
There was a problem hiding this comment.
It looks good, my only comment is that moving the parsing of the entry point doesn't solve the general problem of memory overwrite when loading the ELF.
In other archs application and wolfBoot agreed on separating completely the areas where can ELF can be loaded from the memory used by wolfBoot. This way, as the ELF is verified, we can put the responsibility of not using any memory area used by wolfBoot on the ELF.
rizlik
approved these changes
Jun 24, 2025
danielinux
approved these changes
Jun 24, 2025
Contributor
Author
|
The wolfHSM tests are having issues (hanging). @bigbrett is looking into and will followup with a separate PR. |
dgarske
commented
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for PowerPC 32-bit SHA256 assembly speedups.
entrytopentryto avoid confusion with GET_H64 macro's use of header member "entry".hal/nxp_p1021.c