Fixes with max size, openssl.test netcat and clang-tidy#8909
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Jun 23, 2025
Merged
Fixes with max size, openssl.test netcat and clang-tidy#8909douzzer merged 1 commit intowolfSSL:masterfrom
douzzer merged 1 commit intowolfSSL:masterfrom
Conversation
…fssl/wolfcrypt/asn.h:1375:18: error: use of undeclared identifier 'WC_MAX_DIGEST_SIZE`. Fixed netcat issue in openssl.test causing server open check to fail on some platforms. Fixed clang-tidy report in benchmark.c where XFTELL could return negative (error) and wasn't handled.
Contributor
|
retest this please (tooling failure in ) |
douzzer
approved these changes
Jun 23, 2025
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
tested with wolfssl-multi-test.sh ... super-quick-check cppcheck-force-source
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Jun 27, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wolfssl/wolfcrypt/asn.h:1375:18: error: use of undeclared identifier 'WC_MAX_DIGEST_SIZE. See wolfBoot issue with TPM tests here: Add support for PowerPC 32-bit SHA256 assembly speedups wolfBoot#576Testing
All multi-tests are passing now and various platforms.
Checklist