Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace window timer with injected timer #601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace window timer with injected timer #601

wants to merge 1 commit into from
+809 −559

Commits on Nov 7, 2024

  1. Replace window timer with injected timer 

    Components that use timers are hard to test. This
removed the window timers and replaces them with
an interface that we can mock.

Updates all tests and banners to use the new timer.

Ticket: https://phabricator.wikimedia.org/T378589
    @Abban
    Abban committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    70405d7 View commit details
    Browse the repository at this point in the history