Skip to content

Conversation

@DedeHai
Copy link
Collaborator

@DedeHai DedeHai commented Dec 14, 2025

0.15.1 introduced a new behaviour on how "empty space" is treated. While it is technically correct, it is not user friendly and is a breaking change: all previous versions behaved differently and so does 0.16.

What this change does is to set any unused pixels to black instead of keeping the last value.

0.15.1 introduced a new behaviour on how "empty space" is treated. while it is technically correct, it is not user friendly and is a breaking change: all previous versions behaved differently and so does 0.16.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@softhack007 softhack007 self-requested a review December 15, 2025 20:45
Copy link
Member

@softhack007 softhack007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable. I agree its better to set the previous segment to "black", so to avoid orphaned pixels that stay on the LEDs until the bus driver gets re-initialized.

@DedeHai DedeHai changed the title revert segment behaviour for consistency set unused segments to black Dec 16, 2025
@DedeHai DedeHai merged commit 8b6a571 into wled:0_15_x Dec 16, 2025
20 checks passed
@DedeHai DedeHai deleted the 015_segmentFix branch December 16, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants