LEDs stays ON when changing presets

[dinuxlt]

What happened?

I have multiple presets.
First (and default) preset controls all LEDs from 0 to 179. The color is green.
Second preset controls LEDs from 0 to 20 and color is white
Third preset controls LEDs from 159 to 179 and color is yellow

To Reproduce Bug

Change from default preset (all LEDs are on), to second or third (20 LEDs are colored and ON, the rest should be OFF)

Expected Behavior

With 0.15.0 when I switching from default preset where all LEDs are green to, second, LEDs 0-20 changes his color to white (what is expected), and 21-179 are going OFF. With 0.15.1 and 0.15.2 21-179 LED's are staying green.

Install Method

Binary from WLED.me

What version of WLED?

0.15.1 and 0.15.2

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

Anything else?

I'm not sure which version behaves correctly. There was a bug in 0.15.0 or there is a bug in 0.15.1/0.15.2

Code of Conduct

• I agree to follow this project's Code of Conduct

[DedeHai]

The behaviour you see is intended, whther this was a bug in 0.15.0 or had to be updated to fix other issues I do not know.
If you segment is say 0-50, thats the LEDs its supposed to update and leave others untouched. If you want others black, set them to black.

[dinuxlt]

If you segment is say 0-50, thats the LEDs its supposed to update and leave others untouched. If you want others black, set them to black.

Yes, I understand that.

BUT

Just tested old versions:
0.13.3
0.14.0
0.14.4
0.15.0

And for all these, if I set segment 0-50 LEDs are updated, and let's say 51-200 are turning OFF.
For 0.15.1 and 0.15.2 0-50 LEDs are updated, and 51-200 are staying.

I understand that I should create new segment (51-200 in this case) and turn OFF these LEDs.

What I'm trying to say, that there is no consistency in behaviour between old versions and new (no compatibility). Not sure it was done on purpose or this is side effect of some change.

That's why I market this issue as BUG

[blazoncek]

Please post presets.

[dinuxlt]

Both presets are generated by WLED (using 0.14.x)

Default preset:

{
  "on": false,
  "bri": 15,
  "transition": 7,
  "mainseg": 0,
  "seg": [
    {
      "id": 0,
      "start": 0,
      "stop": 179,
      "grp": 1,
      "spc": 0,
      "of": 0,
      "on": true,
      "frz": false,
      "bri": 255,
      "cct": 127,
      "set": 0,
      "col": [
        [
          179,
          255,
          0
        ],
        [
          0,
          0,
          0
        ],
        [
          0,
          0,
          0
        ]
      ],
      "fx": 0,
      "sx": 128,
      "ix": 128,
      "pal": 0,
      "c1": 128,
      "c2": 128,
      "c3": 16,
      "sel": true,
      "rev": false,
      "mi": false,
      "o1": false,
      "o2": false,
      "o3": false,
      "si": 0,
      "m12": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    }
  ]
}

Second preset:

{
  "on": true,
  "bri": 20,
  "transition": 7,
  "mainseg": 0,
  "seg": [
    {
      "id": 0,
      "start": 140,
      "stop": 160,
      "grp": 1,
      "spc": 0,
      "of": 0,
      "on": true,
      "frz": false,
      "bri": 255,
      "cct": 127,
      "set": 0,
      "col": [
        [
          255,
          255,
          255
        ],
        [
          0,
          0,
          0
        ],
        [
          0,
          0,
          0
        ]
      ],
      "fx": 0,
      "sx": 128,
      "ix": 128,
      "pal": 0,
      "c1": 128,
      "c2": 128,
      "c3": 16,
      "sel": true,
      "rev": false,
      "mi": false,
      "o1": false,
      "o2": false,
      "o3": false,
      "si": 0,
      "m12": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    },
    {
      "stop": 0
    }
  ]
}

[blazoncek]

Remove unused segments form preset and you'll be fine.
You can update existing presets by checking "Selected segments" and making sure only desired segments are checked.

Otherwise get familiar with JSON API.

[dinuxlt]

Thank you for your thoughts.
I'm out now, I'll test when I get back.

[DedeHai]

we have discussed this and decided that this was an unnecessary breaking change. #5192 will fix it in the next release