Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Allow configuring argon2id parameters #4291

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

[feat] Allow configuring argon2id parameters #4291

wants to merge 41 commits into from
+535 −291

Commits on Oct 9, 2024

  1. Removed wrong comment.

    @elland
    elland committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1c80e2b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Thread password hashing options through the env.

    @elland
    elland committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    815481e View commit details
    Browse the repository at this point in the history

  2. Renamed make cmd to avoid accidentally cleaning the whole thing.

    @elland
    elland committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6cd9fb4 View commit details
    Browse the repository at this point in the history

  3. Cleaning up.

    @elland
    elland committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1419f59 View commit details
    Browse the repository at this point in the history

  4. Clean up from review

    @elland
    elland committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    50de042 View commit details
    Browse the repository at this point in the history

  5. Update libs/wire-subsystems/test/unit/Wire/MockInterpreters/HashPassw… 

    …ord.hs

Co-authored-by: Matthias Fischmann <[email protected]>
    @elland @fisx
    elland and fisx authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0277ca6 View commit details
    Browse the repository at this point in the history

  6. Restore necessary reauth logic

    @elland
    elland committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c100cb6 View commit details
    Browse the repository at this point in the history

  7. Added a changelog.

    @elland
    elland committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    448d81a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Add docs, beef up changelog entrie(s).

    @fisx
    fisx committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bd0a1a7 View commit details
    Browse the repository at this point in the history

  2. Fix: default parameters.

    @fisx
    fisx committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bfe5384 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into configurable-argon

    @fisx
    fisx committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    80c2964 View commit details
    Browse the repository at this point in the history

  4. Fix: do not take a Nothing for options when hashing passwords! 

    Always make sure the options from the server config are used if /a.
    @fisx
    fisx committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    44b726b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. cp info from changelog to docs.

    @fisx @elland
    fisx authored and elland committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    42a0dcb View commit details
    Browse the repository at this point in the history

  2. Fixed typo.

    @elland
    elland committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1f4d18e View commit details
    Browse the repository at this point in the history

  3. Update changelog.d/2-features/add-config-for-pwd-hash

    @fisx
    fisx authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5ab90fe View commit details
    Browse the repository at this point in the history

  4. Fix: remove one more spurious call to scrypt.

    @fisx
    fisx committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4083a34 View commit details
    Browse the repository at this point in the history

  5. wip: Test new params for CI

    @elland
    elland committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c9aab24 View commit details
    Browse the repository at this point in the history

  6. Change the right place

    @elland
    elland committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    85a9e03 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/develop' into configurable-argon

    @elland
    elland committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7154034 View commit details
    Browse the repository at this point in the history

  8. Fix/Add more tests for ssoLogin.

    @elland
    elland committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d678d9b View commit details
    Browse the repository at this point in the history

  9. Make argon2id also fast in local integration tests.

    @fisx
    fisx committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9679e00 View commit details
    Browse the repository at this point in the history

  10. mv argon2id dummy settings from prod to CI. 

    this fixes 85a9e03
    @fisx
    fisx committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    54d2912 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Restore Missing Auth error.

    @elland
    elland committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    62a352b View commit details
    Browse the repository at this point in the history

  2. Update changelog.d/2-features/add-config-for-pwd-hash

    @fisx
    fisx authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    09ca3d2 View commit details
    Browse the repository at this point in the history

  3. Update docs/src/developer/reference/config-options.md

    @fisx
    fisx authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b04b685 View commit details
    Browse the repository at this point in the history

  4. Fixed new test expectation.

    @elland
    elland committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3846046 View commit details
    Browse the repository at this point in the history

  5. Added logging for the hash opts.

    @elland
    elland committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    73da097 View commit details
    Browse the repository at this point in the history

  6. Log also for reg user creation.

    @elland
    elland committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ba549eb View commit details
    Browse the repository at this point in the history

  7. More aggressive logging.

    @elland
    elland committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    dd891b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. charts/brig: Allow configuring password hashing options

    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ab4fea8 View commit details
    Browse the repository at this point in the history

  2. hack/helm_vars: Optimize password hashing options so tests run fast

    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    16723dc View commit details
    Browse the repository at this point in the history

  3. charts/brig: Set defaults for PasswordHashingOptions

    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d2ccad4 View commit details
    Browse the repository at this point in the history

  4. wire-{api,subsystems}: Simplify password hashing options

    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cff50f7 View commit details
    Browse the repository at this point in the history

  5. brig: Adapt for simplified password hashing options 

    - passwordHashingOptions are no longer optional in settings, expect helm
  chart to have set the right defaults.
- Brig.Provider.DB no longer hashes password, it expects hashed password
  to be passed in. Functions at higher level call HashPassword effect.
  These will eventually move to AuthenticationSubsystem (or something
  similar for providers)
    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e0fa88d View commit details
    Browse the repository at this point in the history

  6. galley: Allow configuring password hashing options

    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a3d5bfe View commit details
    Browse the repository at this point in the history

  7. hack/helm_var: Configure password hashing options for galley 

    Optimize for test run time, not security.
    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ec11876 View commit details
    Browse the repository at this point in the history

  8. brig: Removed debug logging 

    Was here to inspect CI env.
    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5ff3b18 View commit details
    Browse the repository at this point in the history

  9. Lint out redundant language pragma.

    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    50c6685 View commit details
    Browse the repository at this point in the history

  10. Update changelog and docs for galley and brig 

    Reorg changelog, so important things go on top.
    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    721e2ff View commit details
    Browse the repository at this point in the history

  11. Lint+

    @elland
    elland committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dc7f299 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. galley: Local integration config missing.

    @elland
    elland committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e256d56 View commit details
    Browse the repository at this point in the history