[feat] Allow configuring argon2id parameters #4291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
elland
commented
Oct 10, 2024
fisx
reviewed
Oct 10, 2024
libs/wire-subsystems/src/Wire/AuthenticationSubsystem/Interpreter.hs
Outdated
Show resolved
Hide resolved
libs/wire-subsystems/test/unit/Wire/MockInterpreters/HashPassword.hs
Outdated
Show resolved
Hide resolved
…ord.hs Co-authored-by: Matthias Fischmann <[email protected]>
fisx
reviewed
Oct 10, 2024
Always make sure the options from the server config are used if /a.
fisx
requested changes
Oct 11, 2024
Comment on lines
-392
to
-402
| (Data.reauthenticate uid Nothing) `catchE` \case | ||
| ReAuthMissingPassword -> pure () | ||
| ReAuthCodeVerificationRequired -> pure () | ||
| ReAuthCodeVerificationNoPendingCode -> pure () | ||
| ReAuthCodeVerificationNoEmail -> pure () | ||
| ReAuthError e -> case e of | ||
| AuthInvalidUser -> throwE LoginFailed | ||
| AuthInvalidCredentials -> pure () | ||
| AuthSuspended -> throwE LoginSuspended | ||
| AuthEphemeral -> throwE LoginEphemeral | ||
| AuthPendingInvitation -> throwE LoginPendingActivation |
There was a problem hiding this comment.
this change is extremely hard to understand, and i think it has at least one error hidden deep inside: BadCredentials and InvalidUser are flipped.
are all the changes in names, order, and structure really necessary?
elland
force-pushed
the
configurable-argon
branch
from
2360f08
to
1f4d18e
Compare
fisx
reviewed
Oct 14, 2024
fisx
reviewed
Oct 15, 2024
akshaymankar
changed the title
- passwordHashingOptions are no longer optional in settings, expect helm chart to have set the right defaults. - Brig.Provider.DB no longer hashes password, it expects hashed password to be passed in. Functions at higher level call HashPassword effect. These will eventually move to AuthenticationSubsystem (or something similar for providers)
Optimize for test run time, not security.
Was here to inspect CI env.
akshaymankar
changed the title
Reorg changelog, so important things go on top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-9746
Checklist
changelog.d