-
Notifications
You must be signed in to change notification settings - Fork 24
fix: pull to refresh mechanism - WPB-21415 #3820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pull to refresh mechanism - WPB-21415 #3820
Conversation
WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesView.swift
Show resolved
Hide resolved
Test Results2 095 tests 2 068 ✅ 10m 39s ⏱️ Results for commit a4178d9. ♻️ This comment has been updated with latest results. |
….com/wireapp/wire-ios into fix/files-search-bar-hiding-on-refresh
WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesViewModel.swift
Show resolved
Hide resolved
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesViewModel.swift
Show resolved
Hide resolved
netbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm;)
Issue
This PR fixes a couple of issues found on the files views:
searchTextinput to the API instead of nil when there's no active search.Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: