Skip to content

Conversation

@jullianm
Copy link
Contributor

@jullianm jullianm commented Nov 3, 2025

BugWPB-21415 [iOS] Pull to refresh hides the search bar and whole page shows blank for a fraction of second

Issue

This PR fixes a couple of issues found on the files views:

  • pull to refresh mechanism which had a weird UI behavior because we were relying on our own loading mechanism instead of the built-in one.
  • files not being updated properly because we were passing an empty searchText input to the API instead of nil when there's no active search.
  • when showing up for the first time, files views seem to be loading twice causing a small UI glitch. issue is that the search binding is initially triggered twice consecutively whereas it should not be.

Testing

  • when pulling to refresh whether in the Files tab or in the convo view, current items should still be visible, no blank screen and the search bar still shows up in the files tabs. then loading indicator shows up and refreshes the items properly

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested review from a team, netbe and samwyndham and removed request for a team November 3, 2025 08:47
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Test Results

2 095 tests   2 068 ✅  10m 39s ⏱️
  347 suites     27 💤
    3 files        0 ❌

Results for commit a4178d9.

♻️ This comment has been updated with latest results.

….com/wireapp/wire-ios into fix/files-search-bar-hiding-on-refresh
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;)

@jullianm jullianm merged commit f5462ec into release/cycle-4.9 Nov 3, 2025
11 checks passed
@jullianm jullianm deleted the fix/files-search-bar-hiding-on-refresh branch November 3, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants