Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2025

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-21415 [iOS] Pull to refresh hides the search bar and whole page shows blank for a fraction of second

Issue

This PR fixes a couple of issues found on the files views:

  • pull to refresh mechanism which had a weird UI behavior because we were relying on our own loading mechanism instead of the built-in one.
  • files not being updated properly because we were passing an empty searchText input to the API instead of nil when there's no active search.
  • when showing up for the first time, files views seem to be loading twice causing a small UI glitch. issue is that the search binding is initially triggered twice consecutively whereas it should not be.

Testing

  • when pulling to refresh whether in the Files tab or in the convo view, current items should still be visible, no blank screen and the search bar still shows up in the files tabs. then loading indicator shows up and refreshes the items properly

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm enabled auto-merge November 3, 2025 16:14
@jullianm jullianm closed this Nov 3, 2025
auto-merge was automatically disabled November 3, 2025 16:18

Pull request was closed

@jullianm jullianm reopened this Nov 3, 2025
@jullianm jullianm enabled auto-merge November 3, 2025 16:18
@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 3, 2025

Test Results

203 tests   203 ✅  5m 47s ⏱️
 41 suites    0 💤
  1 files      0 ❌

Results for commit 3006f90.

@jullianm jullianm added this pull request to the merge queue Nov 3, 2025
Merged via the queue into develop with commit 17a78dd Nov 3, 2025
9 checks passed
@jullianm jullianm deleted the fix/files-search-bar-hiding-on-refresh-cherry-pick branch November 3, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants