Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to increase quality of the codebase #1654

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Try to increase quality of the codebase #1654

wants to merge 25 commits into from

Commits on Oct 31, 2024

  1. Map: Uses cb1 constant for legacy post type 

    * Now the code makes it more clear that this is backward compatibility support for CB1.
    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1e8978c View commit details
    Browse the repository at this point in the history

  2. API: Also return empty list as valid response 

    * Add specs to docblock

* Remove unused imports
    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c9bb779 View commit details
    Browse the repository at this point in the history

  3. CB1: Add accessed variables as class members 

    * This will be deprecated in future php versions (8.2) and may be removed later on.
  Maybe CB1 legacy code will stay a bit longer, so this could break.
    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3042e8f View commit details
    Browse the repository at this point in the history

  4. makes base constructor final for safe usage of new static()

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2392857 View commit details
    Browse the repository at this point in the history

  5. Plugin: removed unused saveOptionsActions

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ab8784b View commit details
    Browse the repository at this point in the history

  6. Refactors doc block to match return type of void

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c339bbd View commit details
    Browse the repository at this point in the history

  7. Adds docblocks with matching return types to setCustomColumnSortOrder

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    22a76b8 View commit details
    Browse the repository at this point in the history

  8. Fix phpdoc return type

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ccb617b View commit details
    Browse the repository at this point in the history

  9. several missing return statements

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    73a2734 View commit details
    Browse the repository at this point in the history

  10. Fix several phpdoc WP_Query annotations

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0fc16f8 View commit details
    Browse the repository at this point in the history

  11. Makes UserWidget compliant with parent type 

    * adds return statement
    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8d483b3 View commit details
    Browse the repository at this point in the history

  12. removes typo

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f6a226c View commit details
    Browse the repository at this point in the history

  13. Fix phpdoc use correct timeframe type

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    79c7093 View commit details
    Browse the repository at this point in the history

  14. make type hint picked up without import

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a0aab11 View commit details
    Browse the repository at this point in the history

  15. add docblock

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    dcc84e1 View commit details
    Browse the repository at this point in the history

  16. ruleParams is always an empty list

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0ab0172 View commit details
    Browse the repository at this point in the history

  17. missing import

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6e3f88e View commit details
    Browse the repository at this point in the history

  18. removes unused param and fix phpdoc

    @datengraben
    datengraben committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    64e4f17 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'master' into feature-codequality

    @datengraben
    datengraben authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2457a28 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. declares undeclared variables

    @datengraben
    datengraben committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    492e3b4 View commit details
    Browse the repository at this point in the history

  2. adds phpdoc details

    @datengraben
    datengraben committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    1a19bde View commit details
    Browse the repository at this point in the history

  3. phpdoc: add properties to detect magic methods members

    @datengraben
    datengraben committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    ad4e372 View commit details
    Browse the repository at this point in the history

  4. Tests: removes unused Timeframe call and variable

    @datengraben
    datengraben committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    00ade2e View commit details
    Browse the repository at this point in the history

  5. TimeframeExport: Moves method call to catch ExportException in constr… 

    …uctor

also adds phpdoc
    @datengraben
    datengraben committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    caac319 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Merge branch 'master' into feature-codequality

    @datengraben
    datengraben authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    b4fed3b View commit details
    Browse the repository at this point in the history