Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to increase quality of the codebase #1654

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Try to increase quality of the codebase #1654

wants to merge 24 commits into from
+147 −62

Conversation

datengraben
Copy link
Contributor

@hansmorb

  • Fixes missing imports, typos in type hints (though syntactically correct)
  • Adds or fixes docblocks
  • Adds missing return statements of functions that are not void

@datengraben
Map: Uses cb1 constant for legacy post type
1e8978c 
* Now the code makes it more clear that this is backward compatibility support for CB1.
@datengraben
API: Also return empty list as valid response
c9bb779 
* Add specs to docblock

* Remove unused imports
@datengraben
CB1: Add accessed variables as class members
3042e8f 
* This will be deprecated in future php versions (8.2) and may be removed later on.
  Maybe CB1 legacy code will stay a bit longer, so this could break.
@datengraben
makes base constructor final for safe usage of new static()
2392857
@datengraben
Plugin: removed unused saveOptionsActions
ab8784b
@datengraben
Refactors doc block to match return type of void
c339bbd
@datengraben
Adds docblocks with matching return types to setCustomColumnSortOrder
22a76b8
@datengraben
Fix phpdoc return type
ccb617b
@datengraben
several missing return statements
73a2734
@datengraben
Fix several phpdoc WP_Query annotations
0fc16f8
@datengraben
Makes UserWidget compliant with parent type
8d483b3 
* adds return statement
@datengraben
removes typo
f6a226c
@datengraben
Fix phpdoc use correct timeframe type
79c7093
@datengraben
make type hint picked up without import
a0aab11
@datengraben
add docblock
dcc84e1
@datengraben
ruleParams is always an empty list
0ab0172
@datengraben
missing import
6e3f88e
@datengraben
removes unused param and fix phpdoc
64e4f17
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 50.39%. Comparing base (665d7e9) to head (caac319).

Files with missing lines Patch % Lines
src/Wordpress/CustomPostType/Map.php 0.00% 2 Missing ⚠️
src/API/AvailabilityRoute.php 0.00% 1 Missing ⚠️
src/Model/CustomPost.php 0.00% 1 Missing ⚠️
src/Repository/CB1.php 0.00% 1 Missing ⚠️
src/Service/BookingRuleApplied.php 0.00% 1 Missing ⚠️
src/Wordpress/CustomPostType/Location.php 0.00% 1 Missing ⚠️
src/Wordpress/CustomPostType/Timeframe.php 50.00% 1 Missing ⚠️
src/Wordpress/Widget/UserWidget.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1654      +/-   ##
============================================
- Coverage     50.41%   50.39%   -0.02%     
+ Complexity     2719     2718       -1     
============================================
  Files            99       99              
  Lines         11296    11298       +2     
============================================
- Hits           5695     5694       -1     
- Misses         5601     5604       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datengraben datengraben added technical Non-functional changes (refactorings or increase test coverage) dx Developer Experience (technical) php Pull requests that update Php code documentation labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansmorb hansmorb Awaiting requested review from hansmorb

Assignees
No one assigned
Labels
documentation dx Developer Experience (technical) php Pull requests that update Php code technical Non-functional changes (refactorings or increase test coverage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@datengraben