Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Add Frame connector #278

Closed
wants to merge 12 commits into from
Closed

Conversation

goosewobbler
Copy link

@goosewobbler goosewobbler commented May 9, 2023

Description

New connector for Frame - Uses injected provider if available, otherwise connects using eth-provider.

Connector request: #265
Main repo PR: wevm/wagmi#2296

Additional Information

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

🦋 Changeset detected

Latest commit: 4389532

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wagmi/connectors Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@goosewobbler goosewobbler mentioned this pull request May 9, 2023
1 task
@socket-security
Copy link

socket-security bot commented May 9, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@socket-security
Copy link

socket-security bot commented Jun 20, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ethereum-provider 0.7.7 None +0 50.2 kB cjm
eth-provider 0.13.6 network, filesystem, environment +7 1.18 MB cjm

@salil-naik
Copy link
Contributor

Hey @goosewobbler, is anything pending or missing in this PR? Was wondering why it's not yet merged.

@goosewobbler
Copy link
Author

@salil-naik Nothing missing as far as I can tell. I'm still awaiting feedback or merge from a maintainer. I don't actually work for Frame any more but happy to push this through as the likely alternative is that it will be abandoned.

@dirtycajunrice
Copy link

@salil-naik Nothing missing as far as I can tell. I'm still awaiting feedback or merge from a maintainer. I don't actually work for Frame any more but happy to push this through as the likely alternative is that it will be abandoned.

@goosewobbler If you would like to give me access to this fork, i would like to clean up the failing checks and the injection logic to get this PR to merge-able

@goosewobbler
Copy link
Author

@dirtycajunrice added

@tmm
Copy link
Member

tmm commented Aug 31, 2023

Appreciate the effort that went into this! We've been busy with other work so haven't had time to support new connectors. We are reworking how connectors are setup (directly in the wagmi repo instead of references, new API, etc.) so once that is done this can be created again. Stayed tuned to the wagmi discussion board for more info.

@tmm tmm closed this Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants