add Frame support

[goosewobbler]

Adding injected support for Frame.

[vercel]

@goosewobbler is attempting to deploy a commit to the LFE Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
connectkit-cra	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2023 7:13am
connectkit-nextjs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2023 7:13am
connectkit-testbench	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2023 7:13am
connectkit-vite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2023 7:13am

[lochie]

Hey @goosewobbler, is this teal colour on the logo following brand guidelines for Frame? I haven't seen their logo used in this manner before.

[goosewobbler]

Hey @goosewobbler, is this teal colour on the logo following brand guidelines for Frame? I haven't seen their logo used in this manner before.

Yes, we're trying a logo that will work both on dark and light themes. This logo variant is currently used as the "connected" state of the companion extension.

[goosewobbler]

@lochie Is there anything left to do here? How might I replace the provider? We have an extensionless method of connection via eth-provider, but I couldn't see a way of implementing that here. For example, our onboard connector checks for the injected provider and uses that if present, otherwise it initialises eth-provider:

https://github.com/goosewobbler/web3-onboard/blob/frame-connector/packages/frame/src/index.ts#L20

We also have a new WAGMI connector on the way which will support both connection mechanisms:

wevm/wagmi#2296
wevm/references#278

[lochie]

Yes, we're trying a logo that will work both on dark and light themes. This logo variant is currently used as the "connected" state of the companion extension.

@goosewobbler you could always use the theme variables to define the icon colour within the svg e.g var(--ck-body-color)

[lochie]

@goosewobbler sorry for the delay on this, this lgtm for the injected provider being detected, we're happy to merge this in.

regarding eth-provider, we have a PR that will open this sort of functionality on the way, just waiting for some reviews.

with regards to the wagmi connector, if that gets merged into wagmi we will actively set up support for it within our default setup as we want to keep 1:1 parity with whatever wagmi supports.

sorry again for the delay, and thanks for the contribution! 😊