This repository has been archived by the owner on Mar 28, 2024. It is now read-only.
feat: remove solution_name field from test results #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all mentions to the field
solution_namein test results json's as, (per PR#300 on the frontend repo) this is now fetched with the solution's id.This is sensible, as it changes user inputed data and requires new users to be aware of the change.
Please note that PR#300 on the frontend repo makes
solution_idmandatory in test results, meaning that a test result can, from the moment when that PR is merged on, be merged if the test is performed either by a solution that is in the catalog or by a user that is in the catalog.The CHANGELOG date must be updated before merging.