Merge pull request #62 from wbcsd/solution-name

feat: remove solution_name field from test results
wbcsd · Oct 3, 2023 · bd79cfc · bd79cfc · vercel · Oct 3, 2023
2 parents f5b403d + dd5a659
commit bd79cfc
Show file tree

Hide file tree

Showing 31 changed files with 37 additions and 67 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,11 +2,14 @@
 
 > **_NOTE:_** This file includes all relevant changes to the backend of the [PACT Catalog](https://catalog.carbon-transparency.com). All changes related to the catalog's front end will be listed in the [`pact-catalog-frontend`](https://github.com/sine-fdn/pact-catalog-frontend) repository
 
+## [NEW DATE]
+**************Changed**************
+Remove `solution_name` field from conformance test result `json`s
 
 ## 2023-08-01
 **************Changed**************
 
-Updated Instructions for Adding a PACT Conformance Test result - to allow adding test result for a Conformance test conducted with an organization whose solution is not available on the PACT Catalog 
+Updated Instructions for Adding a PACT Conformance Test result - to allow adding test result for a Conformance test conducted with an organization whose solution is not available on the PACT Catalog
 
 ## 2023-07-20
 **************Changed**************

diff --git a/CONTRIB_TEST.md b/CONTRIB_TEST.md
@@ -28,7 +28,6 @@ Open the `json` file created in step 5. and fill it adapting the following struc
     "version": "<your-solution-version>" // e.g. "0.0.0"
   },
   "tested_by": {
-    "solution_name": "<Solution Name>", // e.g. "Another Solution"
     "version": "<solution-version>",
     "solution_id": "<solution-id>" // e.g. "another-solution"
   },
@@ -37,7 +36,6 @@ Open the `json` file created in step 5. and fill it adapting the following struc
   "pathfinder_version": "<pathfinder-framework-version>" // "1.0.0" or "1.0.1" or "2.0.0" or "2.0.1"
 }
 ```
-The `"solution_id"` property of the `"tested_by"` attribute is optional, but highly recommended. All other fields are mandatory.
 
 <b>Scenario 2:</b> If you tested your solution with an Organization who doesn't have a solution yet or has a solution but not (yet) onboarded to the PACT Catalog
 ```javascript

diff --git a/catalog/conformance-tests/result-atma-io-001.json b/catalog/conformance-tests/result-atma-io-001.json
@@ -4,7 +4,6 @@
     "version": "2.0.1"
   },
    "tested_by": {
-    "solution_name": "TrueCarbon",
     "version": "2.0.0",
     "solution_id": "cirrus-nexus-true-carbon-for-pact-01"
   },

diff --git a/catalog/conformance-tests/result-atma-io-002.json b/catalog/conformance-tests/result-atma-io-002.json
@@ -5,8 +5,7 @@
   },
    "tested_by": {
     "solution_id": "nri-cts",
-    "version": "0.9.15",
-    "solution_name": "NRI-CTS"
+    "version": "0.9.15"
   },
   "test_result": "passed",
   "test_date": "2023-08-09T00:00:00Z",

diff --git a/catalog/conformance-tests/result-booost-gx-001.json b/catalog/conformance-tests/result-booost-gx-001.json
@@ -5,11 +5,10 @@
     },
     "tested_by": {
       "solution_id": "nri-cts",
-      "version": "0.9.15",
-      "solution_name": "NRI-CTS"
+      "version": "0.9.15"
     },
     "test_result": "passed",
     "test_date": "2023-05-22T09:00:00Z",
     "pathfinder_version": "1.0.1",
     "extensions_tested": []
-  }
+  }
diff --git a/catalog/conformance-tests/result-booost-gx-002.json b/catalog/conformance-tests/result-booost-gx-002.json
@@ -5,8 +5,7 @@
     },
     "tested_by": {
       "solution_id": "zeroboard",
-      "version": "2.20.0",
-      "solution_name": "Zeroboard"
+      "version": "2.20.0"
     },
     "test_result": "passed",
     "test_date": "2023-05-22T09:00:00Z",

diff --git a/catalog/conformance-tests/result-carboledger-001.json b/catalog/conformance-tests/result-carboledger-001.json
@@ -5,12 +5,10 @@
     },
     "tested_by": {
       "solution_id": "carbontrail",
-      "version": "1.0.0",
-      "solution_name": "Carbon Trail"
+      "version": "1.0.0"
     },
     "test_result": "passed",
     "test_date": "2023-07-01T06:20:00Z",
     "pathfinder_version": "2.0.0",
     "extensions_tested": []
   }
-
diff --git a/catalog/conformance-tests/result-carboledger-002.json b/catalog/conformance-tests/result-carboledger-002.json
@@ -1,16 +1,14 @@
 {
-    "tested_solution": {
-      "solution_id": "carboledger",
-      "version": "2.0.0"
-    },
-    "tested_by": {
-      "solution_id": "climatecamp",
-      "version": "2.0.0",
-      "solution_name": "ClimateCamp"
-    },
-    "test_result": "passed",
-    "test_date": "2023-07-04T08:16:00Z",
-    "pathfinder_version": "2.0.0",
-    "extensions_tested": []
-  }
-
+  "tested_solution": {
+    "solution_id": "carboledger",
+    "version": "2.0.0"
+  },
+  "tested_by": {
+    "solution_id": "climatecamp",
+    "version": "2.0.0"
+  },
+  "test_result": "passed",
+  "test_date": "2023-07-04T08:16:00Z",
+  "pathfinder_version": "2.0.0",
+  "extensions_tested": []
+}
diff --git a/catalog/conformance-tests/result-carbonblock-001.json b/catalog/conformance-tests/result-carbonblock-001.json
@@ -5,8 +5,7 @@
   },
   "tested_by": {
     "solution_id": "cirrus-nexus-true-carbon-for-pact-01",
-    "version": "2.0.0",
-    "solution_name": "TrueCarbon"
+    "version": "2.0.0"
   },
   "test_result": "passed",
   "test_date": "2023-05-10T09:00:00Z",

diff --git a/catalog/conformance-tests/result-carbonblock-002.json b/catalog/conformance-tests/result-carbonblock-002.json
@@ -5,8 +5,7 @@
   },
   "tested_by": {
     "solution_id": "nri-cts",
-    "version": "2.0.0",
-    "solution_name": "NRI-CTS"
+    "version": "2.0.0"
   },
   "test_result": "passed",
   "test_date": "2023-04-26T09:00:00Z",

diff --git a/catalog/conformance-tests/result-carbontrail-001.json b/catalog/conformance-tests/result-carbontrail-001.json
@@ -5,8 +5,7 @@
   },
   "tested_by": {
     "solution_id": "carboledger",
-    "version": "1.0.0",
-    "solution_name": "Carboledger"
+    "version": "1.0.0"
   },
   "test_result": "passed",
   "test_date": "2023-07-01T09:00:00Z",

diff --git a/catalog/conformance-tests/result-carbontrail-002.json b/catalog/conformance-tests/result-carbontrail-002.json
@@ -5,8 +5,7 @@
   },
   "tested_by": {
     "solution_id": "climatecamp",
-    "version": "2.0.0",
-    "solution_name": "ClimateCamp"
+    "version": "2.0.0"
   },
   "test_result": "passed",
   "test_date": "2023-07-03T09:00:00Z",

diff --git a/catalog/conformance-tests/result-cirrus-nexus-true-carbon-for-pact-01-001.json b/catalog/conformance-tests/result-cirrus-nexus-true-carbon-for-pact-01-001.json
@@ -5,8 +5,7 @@
   },
   "tested_by": {
     "solution_id": "carbonblock",
-    "version": "1.0.0",
-    "solution_name": "CarbonBlock"
+    "version": "1.0.0"
   },
   "test_result": "passed",
   "test_date": "2023-05-11T00:00:00Z",

diff --git a/catalog/conformance-tests/result-cirrus-nexus-true-carbon-for-pact-01-002.json b/catalog/conformance-tests/result-cirrus-nexus-true-carbon-for-pact-01-002.json
@@ -4,7 +4,6 @@
     "version": "2.0.0"
   },
   "tested_by": {
-    "solution_name": "NRI-CTS",
     "version": "0.9.15",
     "solution_id": "nri-cts"
   },

diff --git a/catalog/conformance-tests/result-cirrus-nexus-true-carbon-for-pact-01-003.json b/catalog/conformance-tests/result-cirrus-nexus-true-carbon-for-pact-01-003.json
@@ -4,7 +4,6 @@
     "version": "2.0.0"
   },
   "tested_by": {
-    "solution_name": "Avery Dennison - atma.io",
     "version": "2.0.1",
     "solution_id": "atma-io"
   },

diff --git a/catalog/conformance-tests/result-climatecamp-001.json b/catalog/conformance-tests/result-climatecamp-001.json
@@ -5,11 +5,10 @@
   },
   "tested_by": {
     "solution_id": "carboledger",
-    "version": "1.0.0",
-    "solution_name": "Carboledger"
+    "version": "1.0.0"
   },
   "test_result": "passed",
   "test_date": "2023-07-13T09:00:00Z",
   "pathfinder_version": "2.0.0",
   "extensions_tested": []
-}
+}
diff --git a/catalog/conformance-tests/result-climatecamp-002.json b/catalog/conformance-tests/result-climatecamp-002.json
@@ -5,11 +5,10 @@
   },
   "tested_by": {
     "solution_id": "carbontrail",
-    "version": "1.0.0",
-    "solution_name": "Carbon Trail"
+    "version": "1.0.0"
   },
   "test_result": "passed",
   "test_date": "2023-07-19T11:00:00Z",
   "pathfinder_version": "2.0.0",
   "extensions_tested": []
-}
+}
diff --git a/catalog/conformance-tests/result-ecoassist-prolca-001.json b/catalog/conformance-tests/result-ecoassist-prolca-001.json
@@ -4,7 +4,6 @@
     "version": "2.0.0"
   },
   "tested_by": {
-    "solution_name": "NRI-CTS",
     "version": "0.9.15",
     "solution_id": "nri-cts"
   },

diff --git a/catalog/conformance-tests/result-ecoassist-prolca-002.json b/catalog/conformance-tests/result-ecoassist-prolca-002.json
@@ -4,7 +4,6 @@
     "version": "2.0.0"
   },
   "tested_by": {
-    "solution_name": "Zeroboard",
     "version": "2.20.0",
     "solution_id": "zeroboard"
   },

diff --git a/catalog/conformance-tests/result-fujitsu-001.json b/catalog/conformance-tests/result-fujitsu-001.json
@@ -5,8 +5,7 @@
   },
   "tested_by": {
     "solution_id": "nri-cts",
-    "version": "0.9.15",
-    "solution_name": "NRI-CTS"
+    "version": "0.9.15"
   },
   "test_result": "passed",
   "test_date": "2023-05-24T17:30:00Z",

diff --git a/catalog/conformance-tests/result-fujitsu-002.json b/catalog/conformance-tests/result-fujitsu-002.json
@@ -4,7 +4,6 @@
     "version": "1.0.0"
   },
   "tested_by": {
-    "solution_name": "booost Sustainability Cloud (booost GX)",
     "version": "3.19.1",
     "solution_id": "booost-gx"
   },

diff --git a/catalog/conformance-tests/result-fujitsu-003.json b/catalog/conformance-tests/result-fujitsu-003.json
@@ -4,7 +4,6 @@
     "version": "1.0.0"
   },
   "tested_by": {
-    "solution_name": "Zeroboard",
     "version": "2.20.0",
     "solution_id": "zeroboard"
   },

diff --git a/catalog/conformance-tests/result-nri-cts-001.json b/catalog/conformance-tests/result-nri-cts-001.json
@@ -4,11 +4,10 @@
     "version": "0.9.15"
   },
   "tested_by": {
-    "solution_name": "CarbonBlock",
     "version": "1.0.0",
     "solution_id": "carbonblock"
   },
   "test_result": "passed",
   "test_date": "2023-05-09T06:37:00Z",
   "pathfinder_version": "2.0.0"
-}
+}
diff --git a/catalog/conformance-tests/result-nri-cts-002.json b/catalog/conformance-tests/result-nri-cts-002.json
@@ -4,7 +4,6 @@
     "version": "0.9.15"
   },
   "tested_by": {
-    "solution_name": "Zeroboard",
     "version": "2.20.0",
     "solution_id": "zeroboard"
   },

diff --git a/catalog/conformance-tests/result-nri-cts-003.json b/catalog/conformance-tests/result-nri-cts-003.json
@@ -4,7 +4,6 @@
     "version": "0.9.15"
   },
   "tested_by": {
-    "solution_name": "TrueCarbon",
     "version": "2.0.0",
     "solution_id": "cirrus-nexus-true-carbon-for-pact-01"
   },

diff --git a/catalog/conformance-tests/result-nri-cts-004.json b/catalog/conformance-tests/result-nri-cts-004.json
@@ -4,11 +4,10 @@
     "version": "0.9.15"
   },
   "tested_by": {
-    "solution_name": "booost Sustainability Cloud (booost GX)",
     "version": "3.19.1",
     "solution_id": "booost-gx"
   },
   "test_result": "passed",
   "test_date": "2023-05-26T02:09:00Z",
   "pathfinder_version": "1.0.0"
-}
+}
diff --git a/catalog/conformance-tests/result-nri-cts-005.json b/catalog/conformance-tests/result-nri-cts-005.json
@@ -4,11 +4,10 @@
     "version": "0.9.15"
   },
   "tested_by": {
-    "solution_name": "EcoAssist-Pro/LCA",
     "version": "2.0.0",
     "solution_id": "ecoassist-prolca"
   },
   "test_result": "passed",
   "test_date": "2023-05-26T06:52:00Z",
   "pathfinder_version": "1.0.0"
-}
+}
diff --git a/catalog/conformance-tests/result-nri-cts-006.json b/catalog/conformance-tests/result-nri-cts-006.json
@@ -4,11 +4,10 @@
     "version": "0.9.15"
   },
   "tested_by": {
-    "solution_name": "Avery Dennison - atma.io",
     "version": "2.0.1",
     "solution_id": "atma-io"
   },
   "test_result": "passed",
   "test_date": "2023-08-10T08:03:00Z",
   "pathfinder_version": "2.0.0"
-}
+}
diff --git a/catalog/conformance-tests/result-zeroboard-001.json b/catalog/conformance-tests/result-zeroboard-001.json
@@ -4,7 +4,6 @@
     "version": "2.20.0"
   },
   "tested_by": {
-    "solution_name": "NRI-CTS",
     "version": "0.9.15",
     "solution_id": "nri-cts"
   },

diff --git a/catalog/conformance-tests/result-zeroboard-002.json b/catalog/conformance-tests/result-zeroboard-002.json
@@ -4,7 +4,6 @@
     "version": "2.20.0"
   },
   "tested_by": {
-    "solution_name": "booost Sustainability Cloud (booost GX)",
     "version": "3.19.1",
     "solution_id": "booost-gx"
   },

diff --git a/catalog/examples/conformance-tests/result-example-solution-001.json b/catalog/examples/conformance-tests/result-example-solution-001.json
@@ -5,8 +5,7 @@
   },
   "tested_by": {
     "solution_id": "second-solution",
-    "version": "0.0.0",
-    "solution_name": "A Second Solution"
+    "version": "0.0.0"
   },
   "test_result": "passed",
   "test_date": "2023-04-13T09:00:00Z",