Update coverage check workflow #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr0me
force-pushed
the
enhancement/updgrade-llvm-version-on-coverage-workflow
branch
from
9c91869 to
63b3cea
Compare
jr0me
changed the title
With the latest github runner for linux (ubuntu 24), clang 16 is now part of the runners default stack. We still add llvm to use llvm-cov as part of the coverage target.
There's no need to check clang tidy rules for the coverage workflow. It is already covered by other actions.
jr0me
force-pushed
the
enhancement/updgrade-llvm-version-on-coverage-workflow
branch
from
befe34d to
6c9bf0c
Compare
cborla
deleted the
enhancement/updgrade-llvm-version-on-coverage-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Github runners were updated to Ubuntu 24, these new runners already include LLVM (and clang) 16 by default. There's no need to manually install a specific version of LLVM. Additionally, since there's now an option to disable clang-tidy checks, we disable them for the coverage checks to speed it up -it's safe to do so, the static analysis already is covered by another workflows-. This PR also enables vcpkg's binary caching, bringing the running time to less than half of what it was previously.