Specify ubuntu runner instead of using latest in coverage check #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github is in a transition period and not all runners use the same version of Ubuntu, since we need 24 to have clang 16 in the runners environment, specify it here.
sdvendramini
approved these changes
Oct 17, 2024
cborla
deleted the
enhancement/specify-ubuntu-runner-for-coverage-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In relation to #218 it was recently also noted that not all runners are using the same
latest, some default to ubuntu-24 others to ubuntu-22. Since Github is in a transition period updating their runners, and they will be so until Oct 30th, we specify the runner in the coverage check to avoid failures.See: actions/runner-images#10636