Add scrolling to layers pane #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news about it ? Latest docker image still have the issue :( |
|
Thanks Luka, Sorry but I don't find the "how to do" such build, do you have any help link ? Thanks |
|
@rroblik currently the simplest way to do it would to have |
13 tasks
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
Fixes wagoodman#469 Fixes wagoodman#494 Fixes wagoodman#540 Refs wagoodman#473 Refs wagoodman#478 Refs wagoodman#520 Co-authored-by: st-gr <[email protected]>
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
Fixes wagoodman#469 Fixes wagoodman#494 Fixes wagoodman#540 Refs wagoodman#473 Refs wagoodman#478 Refs wagoodman#520 Co-authored-by: st-gr <[email protected]>
I was able to build dive from source using the Makefile: The build artifacts should be under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made some changes to handle scrolling when the Layers section is active. I learned Go while doing this so I probably did not do everything The Right Way (tm).. You may need to rewrite some of it (not sure if the extra Buffer is needed in LayerSetState for instance). But it seems to work fine.
Regards,
Teague
Related issue: #469