Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layers pane doesn't scroll when navigating to layer below visible region #469

Open
matt-winfield opened this issue Aug 13, 2023 · 12 comments
Labels
bug Something isn't working

Comments

@matt-winfield
Copy link

What happened:
When viewing an image with more layers than can fit in the "layers" pane, when navigating down to a layer not visible, the pane does not scroll to show it. PageUp / PageDown keys also do not scroll the pane.

What you expected to happen:
The pane should scroll to keep the currently selected layer visible

How to reproduce it (as minimally and precisely as possible):
Open an image with enough layers to not fit into the pane
Navigate down until you go beyond the visible layers.

Environment:

  • OS version - Windows 10 Pro, 22H2, 19045.3324
  • Powershell and Command Prompt, Windows Terminal
  • Docker version - 20.10.16
@matt-winfield matt-winfield added the bug Something isn't working label Aug 13, 2023
@mark2185
Copy link
Contributor

See comment.

I have something in progress, but it's not ready yet, hopefully soon.

@dd84ai
Copy link

dd84ai commented Aug 20, 2023

Screenshot_20230820_181418
Layer Details is missing layer size.
Which makes not accessible info beyond navigating list.
Will be nice adding layer size into Layer Details 😄

@jamshid
Copy link

jamshid commented Sep 3, 2023

TIP: This is a pretty limiting bug and older versions are not available on macOS brew. To workaround it try:

docker run -ti -v /var/run/docker.sock:/var/run/docker.sock wagoodman/dive:v0.10.0 IMAGE:TAG

Btw it doesn't show the full command line though of each RUN so that limits usefulness if you use --build-arg's.

@mark2185
Copy link
Contributor

mark2185 commented Sep 6, 2023

Could you please give #473 a spin to see if it works well enough?

@graffight
Copy link

@mark2185 I've built your branch on Ubuntu 22.04 after having the scrolling bug with v0.11.0, and the bug still happens on your PR branch, built with golang 1.21 :(

@perryrh0dan
Copy link

Any update on this ? I have quiet a lot of layers in my image :(

@moaimullet
Copy link

I just submitted a fix that works for me #478

@st-gr
Copy link

st-gr commented May 10, 2024

@dd84ai: I added the size information to the layer details view (PR 522)
I also added scrolling in the layers view see (PR 521)

joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
@rburgst
Copy link

rburgst commented Nov 29, 2024

any news on that, still broken in 0.12.0 on mac

@DeanAyalon
Copy link

@rburgst #521 fixes this

@rburgst
Copy link

rburgst commented Nov 29, 2024

Not trying to be pushy but do we have an ETA when a release will be available ?

@DeanAyalon
Copy link

DeanAyalon commented Nov 29, 2024

@rburgst this repository is not actively maintained unfortunately

It is unsure yet where things will go, no one has been officially assigned to replace Alex.

joschi's fork has the fix merged in, along with a few others, and some version bumps.
Released as "v0.13.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants