Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update relator codes from Library of Congress #4214

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

dltj
Copy link
Contributor

@dltj dltj commented Jan 28, 2025

Updated from https://www.loc.gov/marc/relators/relacode.html as of 28-Jan-2025

@dltj
Copy link
Contributor Author

dltj commented Jan 28, 2025

We had a library ask for this, so it made sense to update this for everyone.

Note that there was one duplicate code removed from languages/CreatorRoles/en.ini -- Ill was in the code list with a capital 'i' and a lowercase 'i'. I removed the capital 'i'.

@dltj dltj marked this pull request as ready for review January 28, 2025 23:47
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing this, @dltj -- see below for one suggestion.

gis = "Geographic information specialist"
grt = "Graphic technician"
his = "Host institution"
hnr = "Honoree"
hst = "Host"
Ill = "Illustrator"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this here, I wonder if we should add it to languages/CreatorRoles/aliases.ini as Ill = ill (and also remove it from all of the language files with php $VUFIND_HOME/public/index.php language delete CreatorRoles::Ill).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I didn't know about that alias file. I pushed a commit to add a line.

How are translations handled in general? Do I need to do something other than add the lines to en.ini?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding lines to en.ini is enough -- Lokalise will find the changes in GitHub and then when translators work on other languages, they'll be prompted to fill in missing translations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But as noted earlier, in addition to adding the alias, you should also delete the duplicate definition from all of the language files using the tool I mentioned. If that's not working right, maybe I mistyped something; let me know if you need me to dig deeper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants