Skip to content

Remove unnecessary work from ListArray::validate #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamGS merged 1 commit into from
Jan 16, 2026
Merged

Remove unnecessary work from ListArray::validate #6004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 20 additions & 22 deletions vortex-array/src/arrays/list/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,36 +180,34 @@ impl ListArray {
// the elements array.
if let Some(min_max) = min_max(offsets)? {
match_each_integer_ptype!(offsets_ptype, |P| {
let max_offset = P::try_from(offsets.scalar_at(offsets.len() - 1))
.vortex_expect("Offsets type must fit offsets values");

#[allow(clippy::absurd_extreme_comparisons, unused_comparisons)]
{
if let Some(min) = min_max.min.as_primitive().as_::<P>() {
vortex_ensure!(
min >= 0 && min <= max_offset,
"offsets minimum {min} outside valid range [0, {max_offset}]"
);
}
let max = min_max
.max
.as_primitive()
.as_::<P>()
.vortex_expect("offsets type must fit offsets values");
let min = min_max
.min
.as_primitive()
.as_::<P>()
.vortex_expect("offsets type must fit offsets values");

if let Some(max) = min_max.max.as_primitive().as_::<P>() {
Copy link
Contributor Author

@AdamGS AdamGS Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max == max_offset, and if min is >=, so should it be for the same reasons

vortex_ensure!(
max >= 0 && max <= max_offset,
"offsets maximum {max} outside valid range [0, {max_offset}]"
)
}
}
vortex_ensure!(
min >= 0,
"offsets minimum {min} outside valid range [0, {max}]"
);

vortex_ensure!(
max_offset
<= P::try_from(elements.len()).unwrap_or_else(|_| vortex_panic!(
vortex_ensure!(
max <= P::try_from(elements.len()).unwrap_or_else(|_| vortex_panic!(
"Offsets type {} must be able to fit elements length {}",
<P as NativePType>::PTYPE,
elements.len()
)),
"Max offset {max_offset} is beyond the length of the elements array {}",
elements.len()
);
"Max offset {max} is beyond the length of the elements array {}",
elements.len()
);
}
})
} else {
// TODO(aduffy): fallback to slower validation pathway?
Expand Down
Loading