Remove unnecessary work from ListArray::validate
#6004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
added
the
performance
AdamGS
commented
Jan 16, 2026
| if let Some(min) = min_max.min.as_primitive().as_::<P>() { | ||
| vortex_ensure!( | ||
| min >= 0 && min <= max_offset, | ||
| min >= 0, |
Contributor
Author
There was a problem hiding this comment.
at this point we know min is lt_eq the last element, because the offsets array is sorted
AdamGS
commented
Jan 16, 2026
| ); | ||
| } | ||
|
|
||
| if let Some(max) = min_max.max.as_primitive().as_::<P>() { |
Contributor
Author
There was a problem hiding this comment.
max == max_offset, and if min is >=, so should it be for the same reasons
Contributor
|
Because we check is_sorted this is indeed unnecessary |
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // the elements array. | ||
| if let Some(min_max) = min_max(offsets)? { | ||
| match_each_integer_ptype!(offsets_ptype, |P| { | ||
| let max_offset = P::try_from(offsets.scalar_at(offsets.len() - 1)) |
Signed-off-by: Adam Gutglick <[email protected]>
AdamGS
force-pushed
the
adamg/optimize-list-validate
branch
from
3a5f61c to
47353a8
Compare
joseph-isaacs
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some unnecessary work, relying on the previous assertion that the offsets array is sorted.