fix(fspy): handle null ObjectName and Buffer in UNICODE_STRING on Windows#91
Merged
branchseer merged 12 commits intomainfrom Jan 11, 2026
Merged
fix(fspy): handle null ObjectName and Buffer in UNICODE_STRING on Windows#91branchseer merged 12 commits intomainfrom
branchseer merged 12 commits intomainfrom
Conversation
branchseer
force-pushed
the
fix-null-object-name-crash
branch
from
2b56641 to
b07acfd
Compare
fengmk2
approved these changes
Jan 11, 2026
Add hook for NtQueryDirectoryFileEx (newer Windows API) to properly track READ_DIR accesses. This fixes the oxlint_reads_directory test which uses the newer API not covered by NtQueryDirectoryFile. - Add ntdll.dll lookup support for dynamic symbols in DetourAny::attach - Define NtQueryDirectoryFileEx function type (not in ntapi crate) - Use Detour::dynamic for runtime symbol resolution - Update readdir test to use tempdir with cross-platform explanation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--type-awareflag on Windowsfspy_preload_windowsatwinapi_utils.rs:33due to null pointer inslice::from_raw_partsObjectNameor itsBufferfield inUNICODE_STRINGcan be null when tsgolint is spawnedChanges
convert.rs: Check for nullObjectNamebefore dereferencingwinapi_utils.rs: Handle null/emptyBufferby returning empty slice, fixLengthinterpretation (bytes, not u16 count)oxlint_type_awaretest to verify the fixoxlint-tsgolintto test_bins for the testTest plan
cargo test -p fspy oxlint_type_awarepasses--type-awareflag works without crashing🤖 Generated with Claude Code