fix(fspy): handle null ObjectName and correct absolute path logic on Windows#92
Closed
fix(fspy): handle null ObjectName and correct absolute path logic on Windows#92
Conversation
Co-authored-by: branchseer <3612422+branchseer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI failure in pull request 91
fix(fspy): handle null ObjectName and correct absolute path logic on Windows
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows crash when running oxlint with
--type-awareflag and cache invalidation failures. The crash occurred due to null pointer dereference inUNICODE_STRINGhandling. The cache failures occurred because the inverted absolute path logic prevented proper directory tracking.Changes
Path resolution (
convert.rs)RootDirectory, absolute paths pass through\\(UNC) to\(device-relative paths)ObjectNameby checking reference before dereferencingObjectNameis empty, returnRootDirectorypath directly instead of callingPathAllocCombineUNICODE_STRING handling (
winapi_utils.rs)Lengthfield as bytes (was incorrectly treated as u16 count)Bufferby returning empty slice instead of creating invalid pointerSymbol resolution (
detour.rs,nt.rs)NtQueryDirectoryFileExdetour for directory enumeration on newer WindowsTest updates
readdiroperations (Windows requires directory exists to distinguish READ vs READ_DIR access)oxlint_type_awaretest caseExample
Before (crash or wrong path):
After (safe and correct):
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.