Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vro-types] Add VcStorageManager class definition #457

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

VenelinBakalov
Copy link
Collaborator

@VenelinBakalov VenelinBakalov commented Oct 16, 2024

Description

Add the definition of the VcStorageManager class as well as the property in VcServiceContent

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Related issues and PRs

Inherits #449

@VenelinBakalov VenelinBakalov requested a review from a team as a code owner October 16, 2024 06:29
@VenelinBakalov VenelinBakalov added kind/enhancement Enhancement or improvement of existing features area/vro-types Relates to changes to the type definitions version/patch The change is a non-breaking bugfix labels Oct 16, 2024
Copy link
Collaborator

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VenelinBakalov VenelinBakalov merged commit 24c36ae into main Oct 16, 2024
10 checks passed
@VenelinBakalov VenelinBakalov deleted the add-storage-manager-class-definition branch October 16, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vro-types Relates to changes to the type definitions kind/enhancement Enhancement or improvement of existing features version/patch The change is a non-breaking bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants