[vro-types] Add VcStorageManager class definition
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Remco Post <[email protected]>
Signed-off-by: Remco Post <[email protected]>
|
Thanks for adding another type def :) just a reminder to update the release.md |
| */ | ||
| public queryHostsWithAttachedLun (arg0: string): VcHostSystem[]; | ||
|
|
||
| constructor(vimType: string, sdkConnection: VcSdkConnection, moref: VcManagedObjectReference, vimId: string, sdkId: string, vimHost: VcSdkConnection); |
There was a problem hiding this comment.
Are you sure this object has a constructor? I don't see it in the API explorer (but have it mind that i am not with latest version so mine might be outdated)
There was a problem hiding this comment.
I was not able to find any constructor definition for this object in the documentation (API explorer, MOB and so on).
Usually when there is available constructor this should be explicitly defined, e.g.:
| readonly vimId: string; | ||
| readonly sdkId: string; | ||
| readonly vimHost: VcSdkConnection; | ||
|
|
There was a problem hiding this comment.
I see another function in the API - _getRef, maybe it is worth adding it as well
VenelinBakalov
changed the title
VcStorageManager class definition
VenelinBakalov
added
kind/enhancement
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the definition of the VcStorageManager class as well as the property in VcServiceContent
Checklist
Fixed #XXX -orClosed #XXX -prefix to auto-close the issueTesting
n/a