Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Replace satori/go.uuid with existing dependency google/uuid #1552

Merged

Conversation

PushkarJ
Copy link
Contributor

What this PR does / why we need it

satori repo is abandoned. google/uuid has a package uuid
that supports a similar func NewString() that returns
string and panics on any error

Fixes #1543

Describe testing done for PR

Ran all relevant make commands to ensure tests passed and build was successful

Release note

Replace satori/go.uuid with existing dependency google/uuid

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

PR created based on feedback from #1544

satori repo is abandoned. google/uuid has a package uuid
that supports a similar func NewString() that returns
string and panics on any error
@PushkarJ PushkarJ force-pushed the replace-uuid-satori-with-google branch from c7eb2cc to a271284 Compare January 26, 2022 00:24
Copy link
Member

@rajathagasthya rajathagasthya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, and great it is an easy drop in replacement.

@stmcginnis stmcginnis added the ok-to-merge PRs should be labelled with this before merging label Jan 27, 2022
@stmcginnis stmcginnis merged commit 5ea4519 into vmware-tanzu:main Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move satori/go.uuid to google/uuid
4 participants