This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Replace satori/go.uuid with its fork gofrs/uuid #1544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satori repo is abandoned. Its fork gofrs is well maintained and has high security fixes
2 tasks
|
Hi @PushkarJ! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better. |
3 tasks
|
Closing in favor of #1552 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
satori repo is abandoned. Its fork gofrs is well maintained and has high security fixes
Fixes #1543
Describe testing done for PR
Ran all relevant make commands to ensure tests passed and build was successful
Release note
PR Checklist
Additional information
Special notes for your reviewer
Replaced all imports of the unmaintained library with the new one.
Also had to replace: uuid.NewV4() -> uuid.Must(uuid.NewV4()), because the new library returned an error along with the uuid.