This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Handler now accepts customizable routes for liveness and readiness #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattmoyer any chance of reviewing this ? |
|
👍 for this feature ! But maybe you add new method to create handler with custom to avoid breaking change on api. |
Ah yes....that is a better solution. I will do that. |
Signed-off-by: Win Hung <[email protected]>
|
@mattmoyer you can review? :) |
|
@mattmoyer any updates on this PR ? This feature will be very much appreciated 👍 |
|
Could we pretty please get this merged? :D |
|
Any other updates? I really want a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.