Profile Gallery #973
Profile Gallery #973
Conversation
…shows profile tab What works: - can load existing 10011 lists and show images in profile tab What doesn't work: - gallery view is broken - can't load notes to click images to get to original note - adding media to gallery crashes amethyst atm - no functionality to delete media from gallery yet.
(This might still need some tuning but works in general)
|
So, is this one ready to go? Or are we waiting for the NIP repo to move merge? |
|
I had withdrawn my previous PR on the NIPs repo as this was the approach with lists (NIP51) . I haven't made a new PR since. Basically what we need is to reserve the 1163 (or whatever we decide) Kind with an url tag and an e tag. I don't know if this should be part of an existing NIP or a new NIP (it's a pretty simple addition, yet it should be written somewhere sooner or later). In terms of Code, I believe this is ready to go, except you have any suggestions :) |
|
Nice!
That would be a small nip just to define the kind and tags |
|
I made a new PR on the nips repo. |
Here is an alternative attempt at profile galleries. This is an alternative to #957 and only one of both PRs should be used.
The main difference:
This uses kind 1163 (for now) Events per Gallery Entry (Similar to 1063 but with e tag to an event with fileheader info only optional) instead of kind 10011 lists. Here the events represent gallery entries and an infinite amount can exist, where for lists there might be limited by size and have a potential chance to get wiped.
The current state of the PR works in general (add, delete, show)
but it seems it's sometimes having issues to load single events (especially older ones). Not sure if thats a limitation of the filter or if there's some easy way to fix this (Didn't seem to happen for lists)One remaining current limitation is that when a note gets deleted and a gallery entry references to that note, Amethyst will not know and show a loading icon with currently no possiblity to remove the entry