Profile Gallery (List based version) #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shows profile tab What works: - can load existing 10011 lists and show images in profile tab What doesn't work: - gallery view is broken - can't load notes to click images to get to original note - adding media to gallery crashes amethyst atm - no functionality to delete media from gallery yet.
|
"When going back from a note to the gallery, it doesn't remember scroll position and users have to scroll down to the gallery again" Just realised this happens on all feeds in the profile, also the notes and replies. Opened an issue #963 |
|
This is working right now, but I'm converting it to a draft again until there's agreement in nostr-protocol/nips#1340 on how the tags should be named, before it gets merged. |
Merged
|
Trying out your pull request. Is there an entry point from the app ui into your new functionality? |
|
Omg so obvious, I can't believe I missed it! 😂Thanks
…On Sat, 6 Jul 2024, 11:40 believethehype, ***@***.***> wrote:
https://v.nostr.build/7G2me.mp4
—
Reply to this email directly, view it on GitHub
<#957 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANKSV35C25YUZ6TNPJ2QSLZK7CQBAVCNFSM6AAAAABKDGVK2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRG4ZTIMJRG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I think #973 is the better way to move forward, given the limitations of lists, feel free to close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning:
Nostr replaces many different platforms, but hasn't been focusing a lot on visual social media. By adding user galleries, users might add media to a grid so they can showcase some of their content/work to others. This has especially artists, photographers and users of platforms like instagram in mind.
Current Status:
User's can create a Kind 10011 List. (This is not added in nip51 yet, but will be suggested once we are happy with a format)
The current format of tags in that list is
["gallery", "eventid", "urlofmediatoshowingallery"]
(we might need something to differentiate between regular event ids and addressable ones, open for discussion)
The list contains both the id and the url as a user might want to pin the 2nd or 3rd image in a note, and we need the id so we can send users to the original note when clicking the gallery for comments, descriptions etc)
Users in Amethyst have a new Tab in Profile where they can decocrate a "gallery".
When opening media in fullscreen users can use the share button to add media to their gallery
When long pressing media in the gallery they can remove it. (this might take a couple of seconds)
You can of course visit other peoples profiles to see what they share in their Gallery.
Remaining issues:
Update:
Videos now also should work in the Gallery