Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numTrials and randomSeed for Langevin #1403

Merged
merged 6 commits into from
Dec 21, 2024
Merged

numTrials and randomSeed for Langevin #1403

merged 6 commits into from
Dec 21, 2024

Conversation

danv61
Copy link
Contributor

@danv61 danv61 commented Dec 19, 2024

editing and management in the UI - in LangevinOptionsPanel
synchronization with the memory model - SolverTaskDescription and LangevinSimulationOptions (copy constructor, compareEqual)
persistence - XmlReader, XmlProducer,, VCML export / import

@danv61 danv61 added the SpringSaLaD SpringSaLaD integration in VCell label Dec 19, 2024
@danv61 danv61 requested a review from jcschaff December 19, 2024 20:34
@danv61 danv61 self-assigned this Dec 19, 2024
Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look at my comment, and get the trial index from the simtask

@danv61 danv61 requested a review from jcschaff December 20, 2024 19:08
@danv61 danv61 requested a review from jcschaff December 20, 2024 21:05
Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove try/catch for trialIndex retrieval

Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good, approved.

@danv61 danv61 merged commit 1078b55 into master Dec 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SpringSaLaD SpringSaLaD integration in VCell
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants