1231 refine the auth0 login process #1250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the endpoint for forgetting your password.
Allow a HTTP connection when the "isHTTP" property is set to true.
Added the ability to control the URL utilized by the client created to interact with quarkus. Before it assumed that Quarkus and the legacy API where on the same host, but now that doesn't have to be the case. It still makes that assumption if other options aren't provided.
Attempted to incorporate a dynamic path prefix to the quarkus API, but it was unnecessary since no matter if there's an ingress or not the path will always have the prefix /api/v1.
Change the audience for the JWT token to vcellapi because although the domain may be incorrect, the protocol used for that domain is the same for local development, thus one less thing to take care of.
Popup a GUI telling the enduser about the redirection of the browser. Initial creation still needs refinement.
The function already contained within AdminDB existed, but was not an available function to classes external to its module, so I've relaxed the restrictions and made it public.
13 tasks
|
@AvocadoMoon please review this PR and decide what to do with it, sorry that my review was requested 6 months ago. Now this branch has many conflicts and would have to be rebased. - the underlying issue #1231 is closed, does that mean this is obsolete? |
|
Reviewed and it seems that the critical changes:
Is already implemented within the master branch. The assumption is that certain commits from this branch has been cherry picked and placed within master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.