Repository navigation
Recursive dependency linking - #1073
CodeByDrescher wants to merge 23 commits into
Conversation
jcschaff
left a comment
jcschaff
left a comment
There was a problem hiding this comment.
is this code exercised by a unit test? The default GitHub runner is a linux box, and the code should be safe for windows and macos (if tests are run there also).
I imagine that a simple unit test which just runs the local native solvers with no inputs and check for bad return code would work. later we can run that test on multiple runners (windows, mac, linux).
jcschaff
left a comment
jcschaff
left a comment
There was a problem hiding this comment.
add a test for "running" one (or all) native solvers in a basic way (e.g. no args). This is a blind spot for us so is needed anyway. We can chat about the easiest way to test this.
| } | ||
| File[] temp = mySolverLinkDir.listFiles(); | ||
| if (temp == null) throw new NullPointerException(); | ||
| for (File file : temp) { |
There was a problem hiding this comment.
in the latest java, null pointer exceptions give nice contextual messages. I you are going to throw a raw NullPointerException, then you might as well let the for loop fail with a nicely formatted NullPointerException.
This reverts commit d4dd0a1.
|
This is very old, and we currently have no problems described here. Closing |
Fixed issues with linux library linking in recent containers