Recursive dependency linking #1073
Open
+3,677
−3,691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcschaff
reviewed
Dec 8, 2023
There was a problem hiding this comment.
is this code exercised by a unit test? The default GitHub runner is a linux box, and the code should be safe for windows and macos (if tests are run there also).
I imagine that a simple unit test which just runs the local native solvers with no inputs and check for bad return code would work. later we can run that test on multiple runners (windows, mac, linux).
jcschaff
requested changes
Dec 8, 2023
| } | ||
| File[] temp = mySolverLinkDir.listFiles(); | ||
| if (temp == null) throw new NullPointerException(); | ||
| for (File file : temp) { |
There was a problem hiding this comment.
in the latest java, null pointer exceptions give nice contextual messages. I you are going to throw a raw NullPointerException, then you might as well let the for loop fail with a nicely formatted NullPointerException.
This reverts commit d4dd0a1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with linux library linking in recent containers