try dynamic binding for hdf5 for python/linux

virtualcell · Jun 3, 2024 · 6954e6f · 6954e6f
1 parent bb2acd5
commit 6954e6f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/pip.yml b/.github/workflows/pip.yml
@@ -114,7 +114,7 @@ jobs:
       shell: msys2 {0}
       run: |
         platform=windows
-        PATH="/c/Program Files/LLVM/bin:$PATH"
+        PATH="/c/Program Files/LLVM/bin;$PATH"
         pip install --verbose .
       if: matrix.platform == 'windows-latest'
 

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -179,6 +179,10 @@ if(WINDOWS OR WIN32 OR WIN64)
 	set(HDF5_USE_STATIC_LIBRARIES OFF)
 	add_definitions(-DZIP_STATIC)
 endif ()
+if (LINUX AND OPTION_TARGET_PYTHON_BINDING)
+	set(HDF5_USE_STATIC_LIBRARIES OFF)
+endif()
+
 #CMakeList.txt that comes with hdf5 switches library name if compiled with debug
 find_package(HDF5 COMPONENTS HL CXX C)
 set(HDF_VERSION ${HDF5_VERSION})