Skip to content

Conversation

@nicksanford
Copy link
Member

@nicksanford nicksanford commented Oct 17, 2025

Added so that I don't need to do a hack to write reproducible unit tests in the sander project

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Oct 17, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Oct 17, 2025
@github-actions
Copy link
Contributor

Availability

Scene # viamrobotics:main viamrobotics:add-json-encode-decode-support-for-mesh Percent Improvement Health
1 100% 100% 0%
2 100% 100% 0%
3 100% 100% 0%
4 100% 100% 0%
5 100% 100% 0%
6 90% 90% 0%
7 70% 70% 0%
8 100% 100% 0%
9 100% 100% 0%
10 100% 100% 0%

Quality

Scene # viamrobotics:main viamrobotics:add-json-encode-decode-support-for-mesh Percent Improvement Probability of Improvement Health
1 1.31±0.00 1.31±0.00 0% 62%
2 1.52±1.62 0.90±0.00 41% 65%
3 7.37±1.13 7.17±1.85 3% 54%
4 3.53±0.63 3.53±0.63 -0% 50%
5 13.51±5.58 13.51±5.58 -0% 50%
6 13.87±8.17 13.87±8.17 -0% 50%
7 7.34±3.64 7.34±3.64 -0% 50%
8 0.90±0.00 0.90±0.00 -0% 50%
9 4.29±0.21 4.29±0.21 -0% 50%
10 12.67±0.19 12.67±0.19 -0% 50%

Performance

Scene # viamrobotics:main viamrobotics:add-json-encode-decode-support-for-mesh Percent Improvement Probability of Improvement Health
1 0.01±0.00 0.01±0.00 5% 57%
2 0.02±0.00 0.02±0.00 1% 51%
3 0.09±0.03 0.11±0.04 -16% 40%
4 0.66±0.09 0.70±0.11 -7% 38%
5 4.49±3.87 4.51±3.91 -0% 50%
6 3.84±3.03 3.98±3.13 -4% 49%
7 3.16±1.43 3.24±1.48 -3% 48%
8 0.02±0.00 0.02±0.00 3% 58%
9 2.42±0.32 2.43±0.36 -0% 49%
10 8.18±1.49 8.12±1.47 1% 51%

The above data was generated by running scenes defined in the motion-testing repository
The SHA1 for viamrobotics:main is: fc35a8593470e527c87fe1aa0c934a9719fa9f59
The SHA1 for viamrobotics:add-json-encode-decode-support-for-mesh is: fc35a8593470e527c87fe1aa0c934a9719fa9f59

  • 10 samples were taken for each scene

}

// MarshalJSON implements the json.Marshaler interface.
func (m *Mesh) MarshalJSON() ([]byte, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was changing this to a value receiver intentional? This is a 96 byte copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants