RSDK-10211 - create app client from env vars #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
stuqdog
requested review from
a team,
njooma and
lia-viam
and removed request for
a team
viambot
added
safe to test
njooma
requested changes
Mar 18, 2025
app/viam_client.go
Outdated
| @@ -67,6 +70,23 @@ func CreateViamClientWithAPIKey( | |||
| return CreateViamClientWithOptions(ctx, options, logger) | |||
| } | |||
|
|
|||
| // CreateViamClientFromEnvVars creates a ViamClient from env vars set by the module manager. | |||
| // It is intended to be used from within modular resources, and will likely fail if called | |||
| // in another context. | |||
There was a problem hiding this comment.
Can you update this comment as well to enumerate which env vars are need to be set? while i think 95% of the time this will be done via modules, i can see sometimes this actually just being used by normal users too
viambot
added
safe to test
njooma
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for building an app client from env vars, to be used within modular resources.
Blocked on release of #4853