RSDK-8003: Unit tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaney
suggested changes
Jul 12, 2024
bhaney
suggested changes
Jul 12, 2024
| @@ -12,7 +12,7 @@ | |||
| "build": { | |||
| "build": "./build.sh", | |||
| "path": "dist/archive.tar.gz", | |||
| "arch": ["darwin/arm64", "darwin/amd64", "linux/arm64", "linux/amd64"] | |||
| "arch": ["linux/arm64", "linux/amd64"] | |||
| }, | |||
| "entrypoint": "dist/main" | |||
There was a problem hiding this comment.
Is the entrypoint dist/__main__ or dist/main ? it seems like the the Makefile and the meta.json do different things, they should be consistent
There was a problem hiding this comment.
that's my bad, fixing this
src/model_inspector/input_tester.py
Outdated
| from src.model_inspector.utils import is_defined_shape, output_to_shape_dict | ||
| from model_inspector.utils import is_defined_shape, output_to_shape_dict |
There was a problem hiding this comment.
why is it no longer necessary to use the src root directory?
There was a problem hiding this comment.
I moved the test_local.py into src because the imports were acting up when I ran make file
bhaney
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added unit tests, makefile, meta.json, and github workflows
viam build local works on Darwin
Also tested with client using viam server