Package for reading from dinolite usb microscope #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonjerome
requested changes
Feb 8, 2023
keyonjerome
requested changes
Feb 8, 2023
|
very nicely done @wang-edward, small fixes and then this will get merged |
|
wang-edward
commented
Feb 9, 2023
keyonjerome
requested changes
Feb 9, 2023
|
@Nick-palmar can you give this a once-over before merge? |
wang-edward
force-pushed
the
user/wang-edward/217/science-dinolite
branch
from
e9322cc
to
0e70285
Compare
|
Was this tested in any way to make sure it is working properly? |
Yessir💯
|
…b.com/uwrobotics/uwrt_mars_rover into user/wang-edward/217/science-dinolite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#217
Passes CI